Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade electron-builder, electron-updater and electron/notarize #1924

Merged
merged 2 commits into from
Oct 14, 2024

Conversation

Alphrag
Copy link
Member

@Alphrag Alphrag commented Oct 12, 2024

Pre-flight Checklist

Please ensure you've completed all of the following.

Description of Change

Upgrade the electron-builder and electron-updater to the latest version, as well as @electron/notarize.

Motivation and Context

The version of electron-builder and electron-updater have not been updated in a while since it was breaking the builds when rebuilding the sqlite and/or macos-notifcation-state dependencies. The alpha version finally bumps the @electron/rebuild which contains a newer version of gyp fixing the problem encountered. This should also fix the correct upload to the snap store, and improve the auto-update sequences on Windows (by preventing concurrent downloads), as well as improving it for Linux targets.

Additionally, In line with the current dependency of electron-builder, this upgrade notarize and make some changes to push all the required values for the notarization process inside environment variables, to mimic its usage in electron-builder.

Checklist

  • My pull request is properly named
  • The changes respect the code style of the project (pnpm prepare-code)
  • pnpm test passes
  • I tested/previewed my changes locally

Release Notes

Upgrade electron-builder,electron-updater and @electron/notarize to the latest version.

@Alphrag Alphrag requested a review from a team October 13, 2024 15:00
package.json Show resolved Hide resolved
package.json Show resolved Hide resolved
@vraravam vraravam merged commit 1a2e05d into ferdium:develop Oct 14, 2024
5 checks passed
Alphrag added a commit that referenced this pull request Oct 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants