Allow customising shortcuts for activating next/previous service, see #53 #1920
Conversation
insidewhy
changed the title
insidewhy
force-pushed
the
feature/allow-customising-hotkeys
branch
2 times, most recently
from
09544ca
to
d0e291f
Compare
vraravam
force-pushed
the
feature/allow-customising-hotkeys
branch
from
d0e291f
to
d513613
Compare
|
@insidewhy - thanks for submitting the PR. Could you please also attach screenshots of the preference pane, and maybe a small video on how this feature works? |
|
@vraravam I can capture a video of interacting with the preference dialogues but the changes to the keybindings can't be captured with a screen video unless I also video me using my computer keyboard |
np - I was able to test this functionality out in my laptop. For future reference, you can use an app like keycastr to capture key bindings and mouse clicks to demonstrate them 1 suggestion: for macos, the |
|
@vraravam thanks for the suggestions. The default key bindings were taken from the current key bindings used by the app, so I didn't want to change them as part of this PR or it would impact the existing functionality of the app. I suppose this collision between Mac system keybindings and the app has been an issue all this while. If you want to fix it along with this PR I'm happy to do so. |
|
@insidewhy - i noticed (after I posted the above comment), that I used to use That being said, yes, if you can please update the PR to fix this clash, let's have that bug fixed! Thanks! |
insidewhy
force-pushed
the
feature/allow-customising-hotkeys
branch
from
d513613
to
8a5535e
Compare
|
@vraravam BTW I also noticed that changing the shortcuts does not require a restart, so I can remove that message. |
insidewhy
force-pushed
the
feature/allow-customising-hotkeys
branch
2 times, most recently
from
1b77eb9
to
73961a2
Compare
Done |
This allows customising next/previous service shortcuts, but opens the door to using the same code and UI for customizing further shortcuts. These particular shortcuts were requested to be customizable in the github issue ferdium#53
|
@all-contributors please add @insidewhy for code |
|
I've put up a pull request to add @insidewhy! 🎉 |
|
@vraravam Thanks for your help and for merging this so quickly 🎄 |
Pre-flight Checklist
Please ensure you've completed all of the following.
Description of Change
Allow customising certain shortcuts, for now just "activate next service" and "activate previous service".
Also changed default service switch shortcuts from
Cmd+Tab/Cmd+Shift+TabtoCtrl+Tab/Ctrl+Shift+Tabas the former key bindings are already bound by the OS and don't work, see #1920 (comment)Motivation and Context
Ctrl+tab and ctrl+shift+tab are not so ergonomic and this is an action that I use very frequently. This has been requested. Many people complained about these specific keyboard shortcuts in #53 and personally I prefer to use ctrl+, and ctrl+. for this.
Screenshots
Checklist
pnpm prepare-code)pnpm testpassesRelease Notes
Allow customising the keyboard shortcuts used to activate the next and previous services.