Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix windows build script #1897

Merged
merged 1 commit into from
Oct 4, 2024
Merged

Conversation

danny8376
Copy link
Contributor

Pre-flight Checklist

Please ensure you've completed all of the following.

Description of Change

Fix build-windows.ps1 syntax to make it work properly.

Motivation and Context

Make it actually works... Although, probably not much people actually using it.

Checklist

  • My pull request is properly named
  • I tested/previewed my changes locally

Release Notes

none

Copy link
Member

@SpecialAro SpecialAro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you 👍

Copy link
Contributor

@vraravam vraravam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you for fixing the bug @danny8376 !

@vraravam vraravam merged commit 7c811df into ferdium:develop Oct 4, 2024
5 checks passed
@vraravam
Copy link
Contributor

vraravam commented Oct 4, 2024

@all-contributors please add @danny8376 for code

Copy link
Contributor

@vraravam

I've put up a pull request to add @danny8376! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants