Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade electron to '32.0.1' #1834

Merged
merged 1 commit into from
Aug 30, 2024
Merged

Upgrade electron to '32.0.1' #1834

merged 1 commit into from
Aug 30, 2024

Conversation

vraravam
Copy link
Contributor

@vraravam vraravam commented Jun 29, 2024 •
edited
Loading

Pre-flight Checklist

Please ensure you've completed all of the following.

Description of Change

Upgrade electron to '32.0.0'

Motivation and Context

Trying to create a Draft PR - so that the upcoming version can be tested by the contributors on different OSes and hardware architectures (intel vs arm).
Changelog

Screenshots

Checklist

  • My pull request is properly named
  • The changes respect the code style of the project (pnpm prepare-code)
  • pnpm test passes
  • I tested/previewed my changes locally

Release Notes

@vraravam vraravam self-assigned this Jun 29, 2024
Alphrag
Alphrag approved these changes Jun 30, 2024
View reviewed changes
Copy link
Member

@Alphrag Alphrag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems to be working fine for me on MacOS on x64 and Windows 10 x64, and I tested the back and forward interactions which behave as expected.

@vraravam vraravam changed the title Upgrade electron to '32.0.0-alpha.5' [DO NOT MERGE] Upgrade electron to '32.0.0-alpha.9' [DO NOT MERGE] Jul 16, 2024
@vraravam vraravam force-pushed the electron-32 branch 3 times, most recently from b7f53d1 to 0afb6fc Compare July 23, 2024 06:00
@vraravam vraravam changed the title Upgrade electron to '32.0.0-alpha.9' [DO NOT MERGE] Upgrade electron to '32.0.0-beta.1' [DO NOT MERGE] Jul 23, 2024
@vraravam vraravam requested a review from Alphrag July 23, 2024 10:26
@vraravam vraravam force-pushed the electron-32 branch 2 times, most recently from 24261de to 9329c51 Compare July 26, 2024 05:04
@vraravam vraravam changed the title Upgrade electron to '32.0.0-beta.1' [DO NOT MERGE] Upgrade electron to '32.0.0-beta.2' [DO NOT MERGE] Jul 26, 2024
@vraravam vraravam changed the title Upgrade electron to '32.0.0-beta.2' [DO NOT MERGE] Upgrade electron to '32.0.0-beta.3' [DO NOT MERGE] Jul 31, 2024
@vraravam vraravam force-pushed the electron-32 branch 2 times, most recently from d7d5441 to 8099239 Compare August 5, 2024 17:49
@vraravam vraravam force-pushed the electron-32 branch 2 times, most recently from 7f85553 to 6b53ea1 Compare August 9, 2024 22:45
@vraravam vraravam changed the title Upgrade electron to '32.0.0-beta.3' [DO NOT MERGE] Upgrade electron to '32.0.0-beta.5' [DO NOT MERGE] Aug 9, 2024
@vraravam vraravam changed the title Upgrade electron to '32.0.0-beta.5' [DO NOT MERGE] Upgrade electron to '32.0.0' Aug 20, 2024
@vraravam vraravam marked this pull request as ready for review August 30, 2024 16:10
@vraravam vraravam changed the title Upgrade electron to '32.0.0' Upgrade electron to '32.0.1' Aug 30, 2024
@vraravam vraravam merged commit 98dbf80 into ferdium:develop Aug 30, 2024
5 checks passed
@vraravam vraravam deleted the electron-32 branch August 30, 2024 16:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SpecialAro SpecialAro Awaiting requested review from SpecialAro

@Alphrag Alphrag Awaiting requested review from Alphrag

Assignees

@vraravam vraravam

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vraravam @Alphrag