Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade electron to 31.0.0 #1806

Merged
merged 1 commit into from
Jun 11, 2024
Merged

Conversation

vraravam
Copy link
Contributor

Pre-flight Checklist

Please ensure you've completed all of the following.

Description of Change

Upgrade electron to 31.0.0

Motivation and Context

Changelog

Screenshots

Screenshot 2024-06-11 at 10 09 02 AM

Checklist

  • My pull request is properly named
  • The changes respect the code style of the project (pnpm prepare-code)
  • pnpm test passes
  • I tested/previewed my changes locally

Release Notes

@vraravam vraravam requested a review from a team June 11, 2024 04:39
@vraravam vraravam self-assigned this Jun 11, 2024
@vraravam
Copy link
Contributor Author

Tested this on macos m2 machine. Can someone please try it out in other OSes and report back?

@vraravam vraravam marked this pull request as draft June 11, 2024 11:53
@Alphrag
Copy link
Member

Alphrag commented Jun 11, 2024

Running fine after build under Ubuntu 24.04 as well
Screenshot from 2024-06-11 14-16-15

@vraravam vraravam marked this pull request as ready for review June 11, 2024 18:31
@vraravam
Copy link
Contributor Author

thanks @Alphrag for confirming. I'm going to merge this PR now since there are no other objections.

@vraravam vraravam merged commit 2b29b90 into ferdium:develop Jun 11, 2024
5 checks passed
@vraravam vraravam deleted the electron-31.0.0 branch June 11, 2024 18:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants