refactor: various improvements #1296

mcmxcdev · 2023-07-30T02:16:12Z

Pre-flight Checklist

Please ensure you've completed all of the following.

I have read the Contributing Guidelines for this project.
I agree to follow the Code of Conduct that this project adheres to.

Description of Change

enable no-use-before-define eslint rule
shuffle code to conform to no-use-before-define eslint rule
remove btoa dependency which is deprecated and replace with Buffer.from(string).toString('base64')
convert some any types into useful ones
add type annotations where possible
remove unused @types/expect.js
install @types/semver and ts-node which were missing
repair and rewrite add-crowdin-contributors script
remove export keyword from variables which are never consumed in another file
remove unity indicator hack where linked issue was closed
remove module declaration for kebab-case which is unused
add missing state interface for certain components
remove default exports for files which already have a named export
export IRecipePreview so it can be used throughout codebase
remove unused removeCacheForCallWith method from CachedRequest.ts
cleanup unused colors and styles inside legacy theme
improve ColorPickerInput
fix invalid DOM nesting warning with div inside p in EditSettingsForm
fix progressbarAccentColor color picker not updating input when using slider
install missing @types/react-color dependency

Motivation and Context

My initial intention was to get rid of as many any as possible, but then I stumpled upon many more code to improve!

Sorry for the chaotic scope of this one but it's an important one :)

Screenshots

Checklist

My pull request is properly named
The changes respect the code style of the project (pnpm prepare-code)
pnpm test passes
I tested/previewed my changes locally

Release Notes

package.json

scripts/add-crowdin-contributors.ts

src/components/ui/button/index.tsx

src/components/ui/colorPickerInput/index.tsx

src/index.ts

src/themes/default/index.ts

src/api/server/ServerApi.ts

- enable no-use-before-define eslint rule - shuffle code to conform to no-use-before-define eslint rule - remove btoa dependency which is deprecated and replace with Buffer.from(string).toString('base64') - convert some any types into useful ones - add type annotations where possible - remove unused @types/expect.js - install @types/semver and ts-node which were missing - repair and rewrite add-crowdin-contributors script - remove export keyword from variables which are never consumed in another file - remove unity indicator hack where linked issue was closed - remove module declaration for kebab-case which is unused - add missing state interface for certain components - remove default exports for files which already have a named export - export IRecipePreview so it can be used throughout codebase - remove unused removeCacheForCallWith method from CachedRequest.ts - cleanup unused colors and styles inside legacy theme

- fix invalid DOM nesting with div inside p in EditSettingsForm - fix progressbarAccentColor color picker not updating input when using slider - install missing @types/react-color dependency