ci: modernize github actions #1287
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I am not familiar with the location of |
- use `ubuntu-22.04` runner instead of `ubuntu-20.04` - use `windows-2022` runner instead of `windows-2019` - use `pnpm/action-setup` instead of handling `pnpm install` manually - use pnpm-lock.yaml as caching key for actions/cache instead of inexistent package-lock.json - define `packageManager` config option in `package.json` which is read by `pnpm/action-setup`
vraravam
force-pushed
the
ci/modernize-github-actions
branch
from
6c476d0
to
90b7c5f
Compare
vraravam
requested changes
Jul 26, 2023
vraravam
approved these changes
Jul 26, 2023
|
Cool, thanks for finishing this one up Vijay! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pre-flight Checklist
Please ensure you've completed all of the following.
Description of Change
ubuntu-22.04runner instead ofubuntu-20.04windows-2022runner instead ofwindows-2019pnpm/action-setupinstead of handlingpnpm installmanuallypnpm-lock.yamlas caching key foractions/cacheinstead of inexistentpackage-lock.jsonpackageManagerconfig option inpackage.jsonwhich is read bypnpm/action-setupMotivation and Context
Switch to the latest GitHub-hosted runners based on: https://docs.github.com/en/actions/using-jobs/choosing-the-runner-for-a-job#choosing-github-hosted-runners
Screenshots
Checklist
pnpm prepare-code)pnpm testpassesRelease Notes