Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

style: reformat all files properly #1283

Merged

Conversation

mcmxcdev
Copy link
Contributor

@mcmxcdev mcmxcdev commented Jul 25, 2023

Pre-flight Checklist

Please ensure you've completed all of the following.

Description of Change

  • remove .json from .eslintignore
  • add type intellisense to .prettierrc.js
  • install missing @jest/types which is used in jest.config.js for type intellisense
  • split up typecheck and lint into two separate commands
  • remove --require-pragma flag from reformat-files which leads to unformatted files
  • install suggested @types/prop-types and @types/react-loader dependencies
  • add @ts-expect-error to Loader usages
  • reformat all scss files automatically with reformat-files command

Motivation and Context

The project needs to reach a state where all files are properly formatted and we profit from type intellisense where possible.

Screenshots

Checklist

  • My pull request is properly named
  • The changes respect the code style of the project (pnpm prepare-code)
  • pnpm test passes
  • I tested/previewed my changes locally

Release Notes

- remove .json from .eslintignore
- add type intellisense to .prettierrc.js
- install missing @jest/types which is used in jest.config.js
- split up typecheck and lint into two separate commands
- remove --require-pragma flag from reformat-files which leads to unformatted files
- install suggested @types/prop-types and @types/react-loader dependencies
- add @ts-expect-error to Loader usages
- reformat all scss files automatically with reformat-files command
@mcmxcdev mcmxcdev marked this pull request as ready for review July 25, 2023 15:28
@mcmxcdev mcmxcdev requested a review from a team as a code owner July 25, 2023 15:28
package.json Show resolved Hide resolved
package.json Show resolved Hide resolved
@vraravam vraravam merged commit 4bd3d67 into ferdium:develop Jul 26, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants