Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: silence deprecated version and unmet peer dependency warnings #1282

Conversation

mcmxcdev
Copy link
Contributor

Pre-flight Checklist

Please ensure you've completed all of the following.

Description of Change

  • add logged deprecated dependencies to pnpm.allowedDeprecatedVersions
  • configure unmet peer dependencies in pnpm.peerDependencyRules.allowedVersions
  • update used flags in .npmrc

Motivation and Context

Warning logs for deprecated dependencies are popping up on every pnpm install and can be distracting for developers. Instead, now they are silenced and whenever specific dependencies are upgraded, it can be checked if entries from pnpm.allowedDeprecatedVersions can be removed. Pretty much the same is true for dependencies in pnpm.peerDependencyRules.allowedVersions

Screenshots

Before, unmet peer dependency warnings were ignored because they were throwing a warning instead of error only
Screenshot from 2023-07-24 12-56-26

After, no more peer dependency warnings and they would lead to exit code 1

Checklist

  • My pull request is properly named
  • The changes respect the code style of the project (pnpm prepare-code)
  • pnpm test passes
  • I tested/previewed my changes locally

Release Notes

.npmrc Show resolved Hide resolved
.npmrc Show resolved Hide resolved
package.json Show resolved Hide resolved
package.json Show resolved Hide resolved
package.json Show resolved Hide resolved
@mcmxcdev mcmxcdev marked this pull request as ready for review July 24, 2023 19:50
@mcmxcdev mcmxcdev requested a review from a team as a code owner July 24, 2023 19:50
Copy link
Contributor

@vraravam vraravam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please add TODO comments in the code as per the previous comments

- add logged deprecated dependencies to pnpm.allowedDeprecatedVersions
- configure unmet peer dependencies in pnpm.peerDependencyRules.allowedVersions
- update used flags in .npmrc
@vraravam vraravam force-pushed the chore/silence-deprecated-version-and-unmet-peer-dependency-warnings branch from 0bd4917 to 3cd6cb1 Compare July 26, 2023 04:57
@vraravam vraravam merged commit 09d4f8e into ferdium:develop Jul 26, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants