chore: improve lint setup #1281

mcmxcdev · 2023-07-24T02:10:36Z

Pre-flight Checklist

Please ensure you've completed all of the following.

I have read the Contributing Guidelines for this project.
I agree to follow the Code of Conduct that this project adheres to.

Description of Change

update eslint config
merged eslint rules for JS and TS to avoid duplicates
extended stricter lint ruleset from typescript-eslint
corrected wrong setup for certain eslint rulesets
opt in to eslint reportUnusedDisableDirectives config option
fix or disable a lot of lint issues throughout codebase
remove trailingComma: all from prettier config which is default in prettier v3
add volta configuration to package.json to autoload correct node and pnpm versions
upgrade all eslint and prettier related dependencies to latest
remove config options from settings.json which are default anyways
remove config options from settings.json which are outdated/unknown
set up prettier as default formatter in settings.json

Motivation and Context

The lint setup should be up to date so that developers avoid creating bugs or mistakes in the codebase.

Screenshots

Checklist

My pull request is properly named
The changes respect the code style of the project (pnpm prepare-code)
pnpm test passes
I tested/previewed my changes locally

Release Notes

mcmxcdev · 2023-07-24T02:19:43Z

.eslintrc.js

@@ -28,123 +32,50 @@ module.exports = {
    node: true,
    jest: true,
  },
+  reportUnusedDisableDirectives: true,


This config options makes eslint check for eslint-disable statements which are outdated and autoremoves them like in e.g. https://github.com/ferdium/ferdium-app/pull/1281/files#diff-7db082e9f1255575e774bf5f2c4b23b7ed970cedaf3b8a4cf583ac46d19f96b6L71

please raise the similar changes on the ferdium-recipes repo as well. TIA

.eslintrc.js

.prettierrc.js

.vscode/settings.json

package.json

src/api/apiBase.ts

src/app.tsx

src/components/auth/Welcome.tsx

.eslintrc.js

vraravam · 2023-07-24T02:38:10Z

.eslintrc.js

@@ -28,123 +32,50 @@ module.exports = {
    node: true,
    jest: true,
  },
+  reportUnusedDisableDirectives: true,


please raise the similar changes on the ferdium-recipes repo as well. TIA

.eslintrc.js

vraravam

Please remove the addition of the recipes submodule from this PR. Then it can be merged.

mcmxcdev · 2023-07-24T17:33:27Z

Please remove the addition of the recipes submodule from this PR. Then it can be merged.

@vraravam I can't seem to find a way to remove it from being tracked in the PR. I remember having the same issues back with Ferdi.

- update eslint config - merged eslint rules for JS and TS to avoid duplicates - extended stricter lint ruleset from typescript-eslint - corrected wrong setup for certain eslint rulesets - opt in to reportUnusedDisableDirectives config option - fix or disable a lot of lint issues throughout codebase - remove trailingComma: all from prettier config which is default in prettier v3 - add volta configuration to package.json to autoload correct node and pnpm versions - upgrade all eslint and prettier related dependencies to latest - remove config options from settings.json which are default anyways - remove config options from settings.json which are outdated/unknown - set up prettier as default formatter in settings.json