-
Notifications
You must be signed in to change notification settings - Fork 176
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update react-router-dom,react-tooltip& react-transition-group #1260
update react-router-dom,react-tooltip& react-transition-group #1260
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works fine on m1 mac. (Haven't tried teams meeting and screen sharing in any of the configured apps). LGTM
@Alphrag - have you been able to test this on windows? Could anyone else also do the same please? Its been sitting for quite some time now |
f5b1c3b
to
fd479c1
Compare
I accidentally merged this into the develop branch. (Was trying to rebase from develop for latest changes - so that testing can be done with the latest). |
Hey @vraravam 😄 I tested on my windows today and it was working properly! |
@vraravam Nope, there is still the same error that happens when the update bar should appear, as can be seen below... |
@Alphrag That's helpful, Will resolve it :) |
@Alphrag , I tried to replicate failure in mac m1 but it didn't work.
can you help me with this ? or this issue only occure in windows? |
Answering simply for completeness here: the issue also occurred on Mac, and I was able to reproduce it. However, to make the update banner appear, the app must be built without the |
Pre-flight Checklist
Please ensure you've completed all of the following.
Description of Change
Update react-router-dom, react-tooltip & react-transition-group latest version
Motivation and Context
update package to latest version
Checklist
pnpm prepare-code
)pnpm test
passesRelease Notes
history
object when callingcreateBrowserRouter()
remix-run/react-router#9422 (comment)