Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the code signing of builds on windows #1258

Merged
merged 1 commit into from
Jul 1, 2023

Conversation

Alphrag
Copy link
Member

@Alphrag Alphrag commented Jun 30, 2023

Pre-flight Checklist

Please ensure you've completed all of the following.

Description of Change

Remove the code signing step during the build on Windows.

Motivation and Context

The certificate we had to code sign our builds for Windows expired this week, which now prevents the build from completing on Windows.

Checklist

  • My pull request is properly named
  • The changes respect the code style of the project (pnpm prepare-code)

Release Notes

@Alphrag Alphrag requested a review from a team as a code owner June 30, 2023 23:26
@vraravam vraravam merged commit 220eea9 into ferdium:develop Jul 1, 2023
4 checks passed
@Alphrag Alphrag deleted the remove-windows-code-signing branch July 1, 2023 10:24
@fsacer
Copy link

fsacer commented Aug 21, 2023

isn't this kind of a security issue? I've always expected everything to be signed.

@vraravam
Copy link
Contributor

Yes its kind of a security issue; or more specifically, the individual has to trust and verify that the checksums are correct. Unfortunately, we don't have contributors for the $$ needed to get the signing certs.

@Alphrag
Copy link
Member Author

Alphrag commented Aug 21, 2023

isn't this kind of a security issue? I've always expected everything to be signed.

The changes made last June by the certificate authorities forcing the use of hardware keys to hold code signing certificates mean that they have become very expensive to get and need a manual intervention by its owner at each build phase. For these two reasons, we have not been able to keep with signing the releases for Windows. So yes, it is a bit of a security downgrade, and using a self-signing certificate would only make things worse.

I have been looking into the Sigstore project, to see whether we could use it in order to sign our releases and to make them verifiable, but I haven't been able to make a full proof of concept to work with electron-builder yet. But if you know of other means, feel free to let us know (if so, it would be better to start a discussion and tag me there).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants