Update colors in branding README #1233
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Arthur-Huan
changed the title
|
Are there objective reasons why the current branding should be modified? I don’t understand what you mean by “outdated” and “up-to-date”. |
The hex codes do not correspond to the actual colors in the logo. |
|
Oh my bad, that’s right. |
The gradient description is oudated.
SpecialAro
approved these changes
Sep 3, 2023
There was a problem hiding this comment.
LGTM, approving and merging as this is coherent with https://github.com/ferdium/ferdium-branding/blob/main/gradient/gradient.svg
Alphrag
pushed a commit
to Alphrag/ferdium-app
that referenced
this pull request
Oct 8, 2023
Update README.md The gradient description is oudated.
Alphrag
pushed a commit
to Alphrag/ferdium-app
that referenced
this pull request
Oct 14, 2023
Update README.md The gradient description is oudated.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The gradient description is oudated.
Pre-flight Checklist
Please ensure you've completed all of the following.
Description of Change
I tested the current gradient description, and it seems to be an older washed-out gradient (like the Ferdi gradient here: https://appimage.github.io/Ferdi/), so I updated the hex codes and the gradient direction.
Motivation and Context
I was unable to use the current branding information to create the correct logo for my app menu (I use rounded square logos), but I'm sure there are way more benefits to having up-to-date branding information.
Screenshots
Logo made with current gradient information:
Logo with updated gradient information:
Checklist
pnpm prepare-code)pnpm testpassesRelease Notes
Updated the color values for branding.