Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add icons to workspaces #1024

Closed
wants to merge 1 commit into from
Closed

Add icons to workspaces #1024

wants to merge 1 commit into from

Conversation

vraravam
Copy link
Contributor

@vraravam vraravam commented Feb 25, 2023

Pre-flight Checklist

Please ensure you've completed all of the following.

Description of Change

The final intent of this PR is to show the collapsed/expanded sidebar of workspaces with only the icons / favicons as set by the user. If no icon was chosen, then the first character of the workspace name can be used as the default. The intended behavior is similar to the MS Edge browser where the tab bar is vertical position

This is the initial cut to show the first character of the workspace name in a styled box (to the left of the name).
The next items (TODO) still to do as part of this PR will be:

  1. Control showing of this icon via a user preference
  2. Add a grab handle that extends vertically, which when clicked will show/hide the workspace name span element
  3. Store the expanded/collapsed state of the workspace drawer in the preferences store and use it when restarting Ferdium
  4. Styling of the icon
    Currently, this does not handle actual icon files, instead uses the first character of the workspace name. This could be enhanced in the future to support images that the user could upload and can be rendered similar to service icons.

Motivation and Context

#139 (comment)

Screenshots

Checklist

  • My pull request is properly named
  • The changes respect the code style of the project (pnpm prepare-code)
  • pnpm test passes
  • I tested/previewed my changes locally

Release Notes

@mcmxcdev
Copy link
Contributor

Hey @vraravam, are you planning to finish this PR at some point or should we close it?

@vraravam
Copy link
Contributor Author

Closing since I am not working on Ferdium atm.

@vraravam vraravam closed this Sep 24, 2023
@vraravam vraravam deleted the workspace-icons branch September 24, 2023 12:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants