Skip to content

Commit

Permalink
Merge pull request #44 from felixdivo/remove-pypi-pushes
Browse files Browse the repository at this point in the history
Abandon deploy-to-pypi
  • Loading branch information
felixdivo authored Jun 18, 2024
2 parents 1d60f52 + d1b75d8 commit eec2c95
Show file tree
Hide file tree
Showing 2 changed files with 30 additions and 25 deletions.
52 changes: 28 additions & 24 deletions .github/workflows/python-release.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -20,31 +20,35 @@ jobs:
- name: Checkout repository
uses: actions/checkout@v3
- name: Create GitHub Release
uses: softprops/action-gh-release@v1
uses: softprops/action-gh-release@v2
with:
name: Release ${{ github.ref }}
draft: false
body: |
TODO: Add release notes
draft: true
prerelease: false

deploy-to-pypi:
needs: add-github-release # This is important to keep things in sync
name: Deploy as PyPI Package
runs-on: ubuntu-latest
steps:
- name: Checkout repository
uses: actions/checkout@v4
- name: Set up Python
uses: actions/setup-python@v5
with:
python-version: '3.x' # The latest stable version of CPython 3
- name: Install dependencies
run: |
python -m pip install --upgrade pip
pip install build
- name: Build package
run: python -m build ros2_easy_test
- name: Publish package
uses: pypa/gh-action-pypi-publish@81e9d935c883d0b210363ab89cf05f3894778450 # Version v1.8.14
with:
user: __token__
password: ${{ secrets.PYPI_API_TOKEN }}
# This was discontinued because the ROS2 packaging system is enough
#
# deploy-to-pypi:
# needs: add-github-release # This is important to keep things in sync
# name: Deploy as PyPI Package
# runs-on: ubuntu-latest
# steps:
# - name: Checkout repository
# uses: actions/checkout@v4
# - name: Set up Python
# uses: actions/setup-python@v5
# with:
# python-version: '3.x' # The latest stable version of CPython 3
# - name: Install dependencies
# run: |
# python -m pip install --upgrade pip
# pip install build
# - name: Build package
# run: python -m build ros2_easy_test
# - name: Publish package
# uses: pypa/gh-action-pypi-publish@81e9d935c883d0b210363ab89cf05f3894778450 # Version v1.8.14
# with:
# user: __token__
# password: ${{ secrets.PYPI_API_TOKEN }}
3 changes: 2 additions & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -140,8 +140,9 @@ python -m http.server
```

A new version can be released by pusing a new tag starting with `v` to the repository.
This will trigger the CI to build and upload the new version to PyPI and draft a release in GitHub.
This will trigger the CI to draft a release in GitHub that can then be filled with the changelog.
Make sure to update the version number in `package.xml` and `ros2_easy_test/ros2_easy_test/__init__.py` before tagging.
Then, a release via rosdep can be made.

## Changelog

Expand Down

0 comments on commit eec2c95

Please sign in to comment.