Add functionality for MiniDSP 2x4HD

[dennisfrett]

Additional functionality for the MiniDSP driver.

• retrieve the current input source (Analog, Toslink or USB).
• retrieve current configuration slot
• setting volume / muted status

[Lauszus]

Looking good. I've left one comment. Can you address this and then I'll merge it :)

[MarkLido]

I added also the functionality to retrieve current config from MiniDSP 2x4HD.

[dennisfrett]

I added also the functionality to retrieve current config from MiniDSP 2x4HD.

I can check if I can add these later this week. @Lauszus I don't know if you'd rather merge this change in already, or if you'd like to merge everything together later?

[MarkLido]

Better later. After the function for "send" is added!?

[Lauszus]

Okay great. Just let me know when it's ready to get merged :)

[dennisfrett]

I updated the code to also retrieve the current config + I fixed the callback for input source not being called (Might be handy for you, @MarkLido ).

Updating volume has not been done yet.

However, @Lauszus , I'm having an issue, in OnInitSuccessful I do:

        RequestStatus();
        RequestInputSource();
        RequestConfig();

Which send commands, but don't listening for a response, so most of the time the response to the first command (request status), is just lost.

What would you suggest here?

I guess I'm using the library wrong, should I use ctrlReq instead? Or should I somehow busy wait for a response myself?

[MarkLido]

Thanks @dennisfrett. The callback for input source works now. I added also the config callback in the ino. Works perfectly.

[dennisfrett]

@MarkLido I've made a quick implementation for setting volume and muted status.

But I still think I might not be handling synchronous commands correctly, so any input from @Lauszus here would be awesome.

[Lauszus]

Missing new line.

[Lauszus]

Suggested change

	uint8_t SetVolumeCommand[] = {0x42, (uint8_t)(-2*volumeDB)};
	uint8_t SetVolumeCommand[] = {0x42, (uint8_t)round(-2.0f * volumeDB)};

[Lauszus]

Suggested change

	if(volume > 0 || volume < -127.5){
	if(volume < 0 || volume > -127.5) {

[Lauszus]

Suggested change

	void
	void RequestInputSource() const;

[Lauszus]

Suggested change

	void
	void RequestConfig() const;

[Lauszus]

I updated the code to also retrieve the current config + I fixed the callback for input source not being called (Might be handy for you, @MarkLido ).

Updating volume has not been done yet.

However, @Lauszus , I'm having an issue, in OnInitSuccessful I do:

        RequestStatus();
        RequestInputSource();
        RequestConfig();

Which send commands, but don't listening for a response, so most of the time the response to the first command (request status), is just lost.

What would you suggest here?

I guess I'm using the library wrong, should I use ctrlReq instead? Or should I somehow busy wait for a response myself?

An workaround would be to just add delay(1); in between the calls.

[dennisfrett]

@Lauszus Writing this driver without a way too easily debug USB pakets seems quite difficult, and my current implementation has some bugs (delaying inbetween sending doesn't resolve the issue, setting volume only works the first time and not the second time, ...). To make my life easier I've purchased an Atmega32u4 in the hope I can set it up as a USB sniffer (https://github.com/matlo/serialusb).

Once I figure out what's going wrong and fix it, I'll update the PR.