Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed toggle issue #174

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fixed toggle issue #174

wants to merge 1 commit into from

Conversation

ethiebaut
Copy link

I had to fix this in order to be able to make the acm_terminal sample working when connecting to a WaveId PcProx Plus. It seems that the toggle wasn't toggled correctly.

Note that the above comment ("yes, we flip it wrong here so that next time it is actually correct!") may not be accurate now.

I also suspect that line 173 is incorrect as it mixes bmRcvToggle and bmSNDTOGRD but I haven't changed it as it seems to work like this for me, so it's probably expected?

@Lauszus
Copy link
Collaborator

Lauszus commented Sep 15, 2015

@xxxajk can you take a look at this?

@blxd
Copy link

blxd commented Oct 23, 2015

This fixes an issue I have been having too.

@bbx10
Copy link

bbx10 commented Mar 7, 2016

This patch fixes the problem I was having with PS3USB. Previously no buttons and neither joystick worked. With the patch, all buttons and both joysticks are working.

Thanks!

@xxxajk
Copy link
Contributor

xxxajk commented Mar 7, 2016

Will look when I get a chance.... been busy with UHS30 and work, and chipkit support

@baghdasaryan
Copy link

This patch helped address a problem with no characters being printed out to console, when using PcProx USB Badge Reader. Further details on the issue I was having and the resolution are available here: #315

Unless this change has known backwards compatibility issues, I would like to suggest merging it in, as it will solve issues for several projects and prevent new users from spending a bunch of time on debugging.

Otherwise, I think we should update library's FAQ section to link to this issue (I am ready to do that and send a pull request).

@Lauszus
Copy link
Collaborator

Lauszus commented Oct 12, 2017

One that this would be somewhat backwards compatible was to simply use the original code at first and if that fail use this code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants