This repository has been archived by the owner on Feb 8, 2018. It is now read-only.
Modularity #28
Open
Modularity #28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meghprkh
reviewed
Sep 29, 2017
src/routes/comment.js
Outdated
| }, | ||
| { | ||
| method: 'get', | ||
| path: '/:qno/getall', |
There was a problem hiding this comment.
Dont put getall at the back. A GET request already implies that
src/controllers/question.js
Outdated
| @@ -10,24 +10,40 @@ export async function get(ctx) { | |||
| } | |||
|
|
|||
| export async function checkAnswer(ctx) { | |||
| //var wrongAttempts=0 | |||
| var correctAttempts=0 | |||
src/controllers/question.js
Outdated
| }, | ||
| }) | ||
| for(var i in preAnswered){ | ||
| if (preAnswered[i].useranswer in JSON.parse(question.answer)) |
There was a problem hiding this comment.
Store the output of JSON.parse(question.answer) in a variable outside the for loop and use it wherever required. It will avoid recomputing it everytime.
added 2 commits
September 30, 2017 20:46
src/controllers/question.js
Outdated
| @@ -43,7 +44,7 @@ export async function checkAnswer(ctx) { | |||
| } | |||
| ctx.body = { response: true } | |||
| } | |||
| else if(correctAttempts==1) ctx.body = { response: "Already attempted" } | |||
| else if(correctAttempts==1 && (ctx.body.answer in answers)) ctx.body = { response: "Already attempted" } | |||
There was a problem hiding this comment.
Do not put this second condition && (ctx.body.answer in answers), as we would like to send the response as Already attempted irrespective of whether the current answer is right or wrong
|
Fixes #30 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.