[code-review] Rename Crypto to CryptoApi

* make charset static const * Inject CryptoApi via constructor
felangel · Oct 4, 2021 · 62e0861 · 62e0861
1 parent 0666613
commit 62e0861
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 7 deletions.
diff --git a/..._firebase_login/packages/authentication_repository/lib/src/authentication_repository.dart b/..._firebase_login/packages/authentication_repository/lib/src/authentication_repository.dart
@@ -1,7 +1,7 @@
 import 'dart:async';
 
 import 'package:authentication_repository/authentication_repository.dart';
-import 'package:authentication_repository/src/crypto.dart';
+import 'package:authentication_repository/src/crypto_api.dart';
 import 'package:cache/cache.dart';
 import 'package:firebase_auth/firebase_auth.dart' as firebase_auth;
 import 'package:flutter/foundation.dart' show kIsWeb;
@@ -32,15 +32,17 @@ class AuthenticationRepository {
   AuthenticationRepository({
     CacheClient? cache,
     firebase_auth.FirebaseAuth? firebaseAuth,
-    GoogleSignIn? googleSignIn
+    GoogleSignIn? googleSignIn,
+    CryptoApi? cryptoApi
   })  : _cache = cache ?? CacheClient(),
         _firebaseAuth = firebaseAuth ?? firebase_auth.FirebaseAuth.instance,
-        _googleSignIn = googleSignIn ?? GoogleSignIn.standard()
+        _googleSignIn = googleSignIn ?? GoogleSignIn.standard(),
+        _crypto = cryptoApi ?? CryptoApi()
 
   final CacheClient _cache;
   final firebase_auth.FirebaseAuth _firebaseAuth;
   final GoogleSignIn _googleSignIn;
-  final Crypto _crypto = Crypto();
+  final Crypto _crypto;
 
   /// Whether or not the current environment is web
   /// Should only be overriden for testing purposes. Otherwise,

diff --git a/...entication_repository/lib/src/crypto.dart → ...cation_repository/lib/src/crypto_api.dart b/...entication_repository/lib/src/crypto.dart → ...cation_repository/lib/src/crypto_api.dart
@@ -3,13 +3,14 @@ import 'dart:convert';
 
 import 'package:crypto/crypto.dart';
 
-class Crypto {
+class CryptoApi {
+
+  static const charset =
+      '0123456789ABCDEFGHIJKLMNOPQRSTUVXYZabcdefghijklmnopqrstuvwxyz-._';
 
   /// Generates a cryptographically secure random nonce, to be included in a
   /// credential request.
   String generateNonce([int length = 32]) {
-    const charset =
-        '0123456789ABCDEFGHIJKLMNOPQRSTUVXYZabcdefghijklmnopqrstuvwxyz-._';
     var random = Random.secure();
     return List.generate(length, (_) => charset[random.nextInt(charset.length)])
         .join();