player: fix next_song when the following songs are bad #858
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before, next_song returns no song when the following songs are bad. For example, the playlist has [valid_song1, valid_song2, bad_song1, bad_song2] and the current song is valid_song2. At the this time, next_song return None before. After this PR, next_song returns valid_song1.
Pull Request Test Coverage Report for Build 10124380890Details
💛 - Coveralls |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before, next_song returns no song when the following songs are bad. For example, the playlist has [valid_song1, valid_song2, bad_song1, bad_song2] and the current song is valid_song2. At the this time, next_song return None before. After this PR, next_song returns valid_song1.