Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gui: redesign ImgListView #741

Merged
merged 3 commits into from
Dec 29, 2023
Merged

gui: redesign ImgListView #741

merged 3 commits into from
Dec 29, 2023

Conversation

cosven
Copy link
Member

@cosven cosven commented Dec 21, 2023

Before, the left/top most image had spacing(20) to the left and spacing(20) to the top.
Now, they has no spacing to the left/top.

ImgListView code can be refined (do it in anther PR, maybe :)

@coveralls
Copy link

coveralls commented Dec 21, 2023

Pull Request Test Coverage Report for Build 7307608444

  • 134 of 349 (38.4%) changed or added relevant lines in 5 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.1%) to 57.093%

Changes Missing Coverage Covered Lines Changed/Added Lines %
feeluown/gui/pages/search.py 1 4 25.0%
feeluown/gui/helpers.py 5 14 35.71%
feeluown/gui/widgets/img_card_list.py 115 318 36.16%
Totals Coverage Status
Change from base Build 7264905469: -0.1%
Covered Lines: 9039
Relevant Lines: 15832

💛 - Coveralls

@cosven cosven merged commit 300251c into feeluown:master Dec 29, 2023
10 checks passed
@cosven cosven deleted the imglist-enhance branch December 29, 2023 11:54
mokurin000 pushed a commit to waylyrics/FeelUOwn that referenced this pull request Jan 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants