Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: add greenboot-rs ci workflow #126

Merged
merged 1 commit into from
Oct 18, 2023

Conversation

yih-redhat
Copy link
Collaborator

No description provided.

@yih-redhat yih-redhat marked this pull request as draft October 17, 2023 13:11
@yih-redhat yih-redhat marked this pull request as ready for review October 17, 2023 13:12
@nullr0ute
Copy link
Member

This needs to me a PR against the greenboot-rs branch, not main

@yih-redhat
Copy link
Collaborator Author

yih-redhat commented Oct 18, 2023

From my understanding, the workflow files should be put into main branch, then it can be triggered. And it can decide to run for which sub branch. In this case, the workflow will only run for pull_request that targeting greenboot-rs branch, https://github.com/fedora-iot/greenboot/pull/126/files#diff-11b9ad7b2fa47d2680fcd076bb109a944e94a0691a84a53e6b29189a59ccc993R96

For workflow that only exist in non-main branch, I googled it and found some articles that said it should exist in main to be triggered. I also made some test, added workflow in a sub-branch, and then made a pull_request to that sub-branch, the workflow cannot be triggered.

@henrywang, please correct me if I am wrong.

@nullr0ute nullr0ute merged commit c70d83c into fedora-iot:main Oct 18, 2023
12 checks passed
@yih-redhat yih-redhat deleted the greenboot-rs-ci branch October 19, 2023 02:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants