Move the token column from the APIKEY table to the SERVICE table
#33
Conversation
|
Do we need the |
|
If the |
gridhead
changed the title
token column from the APIKEY table to the SERVICE table
|
|
||
| class Service(Base, UUIDCreatableMixin, CreatableMixin): | ||
| __tablename__ = "services" | ||
|
|
||
| id = Column(Integer, primary_key=True, nullable=False) | ||
| user_id = Column(Integer, ForeignKey("users.id", ondelete="CASCADE"), unique=False, nullable=False) | ||
| token = Column(UnicodeText, unique=True, nullable=False, default=uuid4().hex) |
There was a problem hiding this comment.
I don't think that's really necessary to make this token column unique, because services are identified by their uuid column. That said, it's not a blocker.
There was a problem hiding this comment.
The likeliness of us getting a collision on the server side is small but never zero. So that is indeed a valid point that keeps us from getting errors due to weird conditions introduced for the token column. I added the suggested change.
Remove the APIKEY table from the entire database schema Signed-off-by: Akashdeep Dhar <[email protected]>
Nuke the columns
nameandexpiry_dateas they would no longer be needed@brngylni, a couple of points
disabledcolumn).