Dev user endpoint #25
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gridhead
requested review from
abompard and
gridhead
and removed request for
abompard
gridhead
requested changes
Jul 8, 2024
Comment on lines
+2
to
+3
| from ..database import db | ||
| from ..models.user import User |
Comment on lines
57
to
58
|
|
||
|
|
There was a problem hiding this comment.
Leave one empty line at the end of the file.
| @@ -15,7 +15,7 @@ | |||
| from .config.defaults import LOGGER_CONFIG | |||
|
|
|||
| from logging.config import dictConfig | |||
|
|
|||
| from .endpoints.user import user_endpoint | |||
webhook_to_fedora_messaging/main.py
Outdated
| @@ -26,7 +26,7 @@ def create_app(): | |||
| main = Flask( | |||
| "webhook_to_fedora_messaging" | |||
| ) | |||
|
|
|||
There was a problem hiding this comment.
Leave the line empty.
Suggested change
brngylni
force-pushed
the
dev_user_endpoint
branch
from
62b0356
to
a5cd4aa
Compare
gridhead
requested changes
Jul 10, 2024
There was a problem hiding this comment.
Please use the emojis to acknowledge the changes made and leave it for the reviewer to decide if the requested change has been made or not.
Once you are done with making the remaining changes - please squash the commits into one and then, it should be ready for a merge.
brngylni
force-pushed
the
dev_user_endpoint
branch
from
f8b25c5
to
8e0322b
Compare
Done! |
brngylni
force-pushed
the
dev_user_endpoint
branch
from
fdd1167
to
f7b90b3
Compare
brngylni
force-pushed
the
dev_user_endpoint
branch
from
f7b90b3
to
48e25ee
Compare
gridhead
approved these changes
Jul 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the User endpoint #5