Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing ‹requests› dependency to pyproject.toml #365

Merged
merged 1 commit into from
Jun 13, 2024

Conversation

mfocko
Copy link
Contributor

@mfocko mfocko commented May 27, 2024

Related to #364
Related to packit/agile#552

jeremycline
jeremycline previously approved these changes Jun 4, 2024
Copy link
Member

@jeremycline jeremycline left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FWIW, this looks good to me.

Not sure what we need to do to fix up the CI, though.

@jeremycline
Copy link
Member

Ah, you'll need to check in the poetry.lock file as well.

@jeremycline jeremycline dismissed their stale review June 4, 2024 16:15

Needs poetry.lock checked in

@mfocko
Copy link
Contributor Author

mfocko commented Jun 12, 2024

Ah, you'll need to check in the poetry.lock file as well.

I'll have a look at that, it got lost among the other notifications

@mfocko
Copy link
Contributor Author

mfocko commented Jun 12, 2024

Not sure where it's coming from, but I hit this:

fedora-messaging % poetry lock
Updating dependencies
Resolving dependencies... (4.8s)

Package docutils (0.21.post1) not found.

@jeremycline
Copy link
Member

I'm not particularly familiar with poetry, but the CI logs said try poetry lock --no-update which seems to satisfy the tests locally.

@mfocko
Copy link
Contributor Author

mfocko commented Jun 12, 2024

Ah, OK… it works with --no-update 🤦 it was in brackets, so I assumed it's optional

@abompard abompard merged commit e713416 into fedora-infra:develop Jun 13, 2024
16 checks passed
@mfocko mfocko deleted the fix/missing-requests-dep branch June 13, 2024 08:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants