-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
frontend: add commands for adding and removing warning banner #2436
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, thank you for the PR, this would be a helpful feature during release. I made a few notes, and also the documentation change is needed.
05aee50
to
ac378fa
Compare
<div class="alert alert-danger" role="alert"> | ||
{% if outage_time and ticket %} | ||
<b>Warning!</b> Scheduled outage of Copr servers - {{ outage_time }}. For more information | ||
please refer to <a href="https://pagure.io/fedora-infrastructure/issue/{{ ticket }}">this |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm, this is to hardcoded. Especially for people who run their own instance. I would have nothing against it if this file will be in /etc/copr/ and marked as %config
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes it is hardcoded. I meant this to be really specific and strict for our release use cases since we do them often and it is a very specific banner (and we want basically every time the same warning message).
what do you mean by marked as %config? what (and how) do I achieve from it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When the file is in spec file marked as %config then it can be modified by user and it will not be overwritten during dnf upgrade
but .rpmnew file will be created instead.
ac378fa
to
749de73
Compare
I still have a few ideas on how to enhance it, but ... yeah, this works and is better than before. +1 from me. |
TODO:
Fixes #2319