Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace aredis with redis-py #635

Draft
wants to merge 6 commits into
base: master
Choose a base branch
from
Draft

Replace aredis with redis-py #635

wants to merge 6 commits into from

Conversation

wbarnha
Copy link
Member

@wbarnha wbarnha commented Jul 16, 2024

We need to get aredis out of Faust since it uses distutils, a library removed in Python 3.12.

@wbarnha wbarnha self-assigned this Jul 16, 2024
Copy link

codecov bot commented Jul 16, 2024

Codecov Report

Attention: Patch coverage is 90.90909% with 1 line in your changes missing coverage. Please review.

Project coverage is 94.02%. Comparing base (a50e525) to head (f4711d9).

Files Patch % Lines
faust/web/cache/backends/redis.py 83.33% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #635      +/-   ##
==========================================
- Coverage   94.06%   94.02%   -0.05%     
==========================================
  Files         102      102              
  Lines       11091    11098       +7     
  Branches     1548     1549       +1     
==========================================
+ Hits        10433    10435       +2     
- Misses        558      561       +3     
- Partials      100      102       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Luferov
Copy link

Luferov commented Jul 23, 2024

Faust doesn't work with ardis, because aredis support by python until 3.8. Miracle, python 3.9 is working with aredis, Faust with 3.11 doesn't work. We move with aredis to redis-py 🙏

@wbarnha
Copy link
Member Author

wbarnha commented Jul 24, 2024

I'm waiting to merge this until I've tested this against an actual Redis instance.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants