fix: ensure aiokafka commit is called with kafka.structs.TopicPartiti…

[dada-engineer]

Make sure AIOKafkaConsumer.commit() receives compatible TopicPartition class. (Fixes #539)

[codecov]

Codecov Report

Patch coverage: 33.33% and project coverage change: -0.03% ⚠️

Comparison is base (87a80a9) 93.73% compared to head (261e61e) 93.70%.

❗ Current head 261e61e differs from pull request most recent head 1c0102b. Consider uploading reports for the commit 1c0102b to get more accurate results

Additional details and impacted files

@@            Coverage Diff             @@
##           master     #541      +/-   ##
==========================================
- Coverage   93.73%   93.70%   -0.03%     
==========================================
  Files         102      102              
  Lines       11149    11154       +5     
  Branches     1532     1534       +2     
==========================================
+ Hits        10450    10452       +2     
- Misses        611      614       +3     
  Partials       88       88              

Files Changed	Coverage Δ
faust/transport/drivers/aiokafka.py	73.32% <33.33%> (-0.25%)	⬇️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[wbarnha]

Thanks for spending the time investigating this, you wouldn't believe how much of a favor this is. Lint the PR and it should be good!

[dada-engineer]

Thanks for spending the time investigating this, you wouldn't believe how much of a favor this is. Lint the PR and it should be good!

Sorry had it done but not commited yet. 👍🏻

[wbarnha]

Weird, this seems to have fixed the PyPy tests as well? I've never seen them pass before in CI/CD. Thank you, LGTM!

[wbarnha]

Wait, it seems the PyPy test is erroneously marked as passing. I wonder if something in the workflow logic got updated to mark as passing when experimental.

[dada-engineer]

Didn't do anything related to that. Should I?

[wbarnha]

Didn't do anything related to that. Should I?

No need for concern on your end, just got excited too soon about PyPy tests.