Compatibility with upcoming loo package release #29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jgabry
commented
Feb 1, 2024
Comment on lines
+37
to
+43
| if (nrow(k_table) == 4) { | ||
| loo_bad <- k_table["(0.7, 1]", "Count"] | ||
| loo_very_bad <- k_table["(1, Inf)", "Count"] | ||
| } else { | ||
| loo_bad <- k_table[2, "Count"] | ||
| loo_very_bad <- k_table[3, "Count"] | ||
| } |
There was a problem hiding this comment.
This code should work with any version of the loo package now
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We are working on an update to the loo package that affects a few lines of code in your package. This pull request should ensure compatibility with both the current version of loo and the next version.
The change in loo will be that the threshold for flagging pareto k estimates will change from fixed at 0.7 to a threshold determined by the posterior sample size. The resulting table of k estimates computed by
loo::pareto_k_tablewill also now only have three rows for good, bad, and very bad.If you want to test this PR with the version of loo that makes this change you can install that version using
remotes::install_github("stan-dev/loo", ref = "new-pareto-k-threshold").