refactor: make clippy happy with nightly-20241008 #46
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: MrCroxx <[email protected]>
Merged
|
Blocked by rust-lang/rust-clippy#13464 |
|
do you have a issue to the cippy false positive bug? |
Here is it. #46 (comment) |
|
ohhh. I've overseen the comment XD. you can allow the lint with a comment to the issue url. |
Signed-off-by: MrCroxx <[email protected]>
Signed-off-by: MrCroxx <[email protected]>
Signed-off-by: MrCroxx <[email protected]>
|
Bypass the check on the nightly toolchain with |
andylokandy
reviewed
Oct 9, 2024
fastrace/examples/asynchronous.rs
Outdated
| @@ -36,6 +36,8 @@ async fn other_job() { | |||
| } | |||
| } | |||
|
|
|||
| // FIXME: Remove `expect` after the issue is fixed. https://github.com/rust-lang/rust-clippy/issues/13458 | |||
There was a problem hiding this comment.
Please allow the lint in fastrace/Cargo.toml
Signed-off-by: MrCroxx <[email protected]>
andylokandy
approved these changes
Oct 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixed the elided lifetime check. But the needless return warning seems to be a false-positive bug.