fix: validate that fid on username add message matches fid on ens proof #2378
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a bug which allows an users to assume an arbitrary user's ens name as their own.
Merge Checklist
Choose all relevant options below by adding an
x
now or at any time before submitting for reviewPR-Codex overview
This PR focuses on enhancing the validation of
fid
in user data messages to ensure that it matches thefid
associated with the username proof, specifically forfname
andENS
types.Detailed summary
index.ts
to check iffid
matches forfname
andENS
username types.index.test.ts
to verify failure whenfid
on message does not matchfid
on ENS name proof.