Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Signatures): support ERC1271 signatures #286

Merged
merged 1 commit into from
Jul 26, 2023

Conversation

horsefacts
Copy link
Collaborator

@horsefacts horsefacts commented Jul 26, 2023

Motivation

Users should be able to perform signature-authenticated actions like fid registration/transfer and key registration from smart contract wallets.

Change Summary

Replace ECDSA with OpenZeppelin SignatureChecker in the Signatures helper.

Merge Checklist

Choose all relevant options below by adding an x now or at any time before submitting for review

Additional Context

If this is a relatively large or complex change, provide more details here that will help reviewers.


PR-Codex overview

This PR focuses on replacing the usage of ECDSA library with SignatureChecker in multiple contracts.

Detailed summary

  • Replaced ECDSA library import with SignatureChecker import in Signatures.sol
  • Replaced "ECDSA: invalid signature" revert message with Signatures.InvalidSignature.selector in KeyRegistry.t.sol and IdRegistry.t.sol

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@horsefacts horsefacts added the feat New feature request label Jul 26, 2023
@horsefacts horsefacts marked this pull request as ready for review July 26, 2023 20:19
@horsefacts horsefacts force-pushed the horsefacts/erc-1271-signatures branch from 09437f7 to a1ec280 Compare July 26, 2023 21:13
@github-actions
Copy link

Coverage after merging horsefacts/erc-1271-signatures into main will be

98.69%

Coverage Report
FileStmtsBranchesFuncsLinesUncovered Lines
src
   Bundler.sol100%100%100%100%
   FnameResolver.sol100%100%100%100%
   IdRegistry.sol100%100%100%100%
   KeyRegistry.sol100%100%100%100%
   StorageRent.sol100%100%100%100%
src/lib
   Signatures.sol100%100%100%100%
   TransferHelper.sol0%0%0%0%15, 15, 15, 25–26, 26, 26
   TrustedCaller.sol100%100%100%100%

@horsefacts horsefacts merged commit 042fde2 into main Jul 26, 2023
2 checks passed
@horsefacts horsefacts deleted the horsefacts/erc-1271-signatures branch July 26, 2023 21:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feat New feature request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant