feat(Signatures): support ERC1271 signatures #286
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Users should be able to perform signature-authenticated actions like fid registration/transfer and key registration from smart contract wallets.
Change Summary
Replace
ECDSA
with OpenZeppelinSignatureChecker
in theSignatures
helper.Merge Checklist
Choose all relevant options below by adding an
x
now or at any time before submitting for reviewAdditional Context
If this is a relatively large or complex change, provide more details here that will help reviewers.
PR-Codex overview
This PR focuses on replacing the usage of
ECDSA
library withSignatureChecker
in multiple contracts.Detailed summary
ECDSA
library import withSignatureChecker
import inSignatures.sol
"ECDSA: invalid signature"
revert message withSignatures.InvalidSignature.selector
inKeyRegistry.t.sol
andIdRegistry.t.sol