fix(StorageRent): remove noop revokeRole #281
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
This line in the
StorageRent
constructor is a no-op:msg.sender
is not ever granted theDEFAULT_ADMIN_ROLE
, so revoking it here does nothing.Change Summary
Remove the no-op line.
Merge Checklist
Choose all relevant options below by adding an
x
now or at any time before submitting for reviewPR-Codex overview
This PR focuses on granting the
TREASURER_ROLE
to the_initialTreasurer
and revoking theDEFAULT_ADMIN_ROLE
frommsg.sender
.Detailed summary
TREASURER_ROLE
to the_initialTreasurer
.DEFAULT_ADMIN_ROLE
frommsg.sender
.