Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: add slither static analysis checks #197

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

varunsrin
Copy link
Member

Motivation

Describe why this issue should be fixed and link to any relevant design docs, issues or other relevant items.

Change Summary

Describe the changes being made in 1-2 concise sentences.

Merge Checklist

Choose all relevant options below by adding an x now or at any time before submitting for review

Additional Context

If this is a relatively large or complex change, provide more details here that will help reviewers.

@codecov
Copy link

codecov bot commented Mar 4, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (8ae8be1) 84.78% compared to head (507fd39) 84.78%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #197   +/-   ##
=======================================
  Coverage   84.78%   84.78%           
=======================================
  Files           8        8           
  Lines         309      309           
  Branches       81       81           
=======================================
  Hits          262      262           
  Misses         45       45           
  Partials        2        2           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@github-actions
Copy link

github-actions bot commented Mar 4, 2023

Coverage after merging varunsrin/add-slither-part-2 into main will be

94.23%

Coverage Report
FileStmtsBranchesFuncsLinesUncovered Lines
src
   BundleRegistry.sol94.29%83.33%100%100%87, 90
   IdRegistry.sol98.15%100%93.75%98.28%480
   NameRegistry.sol94.56%100%87.10%92.39%1072, 1081, 337, 339, 341, 343, 346, 348–349, 351–352, 354–355, 357

@varunsrin varunsrin force-pushed the varunsrin/add-slither-part-2 branch from 6aad6d3 to 7677f52 Compare March 4, 2023 20:53
@varunsrin varunsrin force-pushed the varunsrin/add-slither-part-2 branch from 7677f52 to 507fd39 Compare March 4, 2023 20:54
This was referenced Mar 5, 2023
@varunsrin
Copy link
Member Author

closing for now, don't think we want slither in ci just yet

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants