Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shorten GB display name #39

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

wilsonpage
Copy link

The recently changed GB display name is:

  • A. Too long to fit in most UIs
  • B. An unfamiliar way to refer to UK. I live in UK and have never heard it called that.

The recently changed GB display name:

- A. Too long to fit in most UIs
- B. An unfamiliar way to refer to UK. I live in UK and have never heard it called that.
@izolate
Copy link

izolate commented Dec 11, 2019

@fannarsh can we merge this? The full name is really unfamiliar for most people in the United Kingdom.

@haochang
Copy link

Just found a way to do it without this PR

overwrite([
      {
        code: 'GB',
        name: 'United Kingdom'
      }
    ])

@daniel-unionrealtime
Copy link

Just found a way to do it without this PR

overwrite([
      {
        code: 'GB',
        name: 'United Kingdom'
      }
    ])

Thank you for this, but I do agree with @wilsonpage here. Without this PR might have taken me longer to find the cause of why:

console.log(getCode('United Kingdom')); // undefined

@fannarsh
Copy link
Owner

fannarsh commented Sep 6, 2023

Hi all,

A. Too long to fit in most UIs.

Yes, it is quite long

B. An unfamiliar way to refer to UK. I live in UK and have never heard it called that.

But this is what it is named according to the United Nations and the ISO 3166-1-alpha-2 standard.

And the sole purpose of this library is to lookup the ISO 3166-1-alpha-2 standard.
You are always welcome to use the overwrite() method to change the names if you want to display another name then the one which is standardised.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants