-
Notifications
You must be signed in to change notification settings - Fork 85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Convert project to esm #24
base: master
Are you sure you want to change the base?
Conversation
Hi @fannarsh! What do you think about this change? |
Hi @TrySound |
Friendly ping @fannarsh if you have some time :) |
Hi again, if you want I can split migrating to tape in a separate PR for simpler review. |
Hi, (I'm not going to close the PR right away, I might change my mind.) |
Let me know if you need to clarify something. |
d214c24
to
d47e70a
Compare
In this diff I migrated the project to esm and provided module field which is useful for bundlers. My usecase is rollup. It is able to handle only esm. And this package requires me to add commonjs and json plugins. As a side bonus this module can be used in browsers without bundlers similar to this https://unpkg.com/jss@next?module. For `tap` I wasn't able to setup esm so I replaced it with `tape`.
I just found that |
Any reason this hasn't been merged? I just searched around and I haven't been able to find an ISO 3166-1-alpha-2 country code package that provides ES modules. I do think there's an opportunity to provide data like country and language ISO codes but avoid bloating bundle sizes. |
@fannarsh: you mentioned you'd take a look at providing an Warning message as found in the output of the Angular 10 build:
|
Any update on this? |
In this diff I migrated the project to esm and provided module field
which is useful for bundlers.
My usecase is rollup. It is able to handle only esm. And this package
requires me to add commonjs and json plugins.
As a side bonus this module can be used in browsers without bundlers
similar to this https://unpkg.com/jss@next?module.
For
tap
I wasn't able to setup esm so I replaced it withtape
.