Configurable chunker #166
Draft
Configurable chunker #166
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
That's the hard part I was talking about. The DI of Paraunit is nowhere accessible from your app: you have to find an input point in the configuration or the CLI options somewhere, so I can't think of an easy way in... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR build on #164 (hence many commits) and implements my comment #164 (comment) (the last commit). During development I've realized what really " it would also be hard to find an easy extension point to attach to..." meant :) I decided to just abstract away the array_chunk from
Runnerand make it technically possible to change the implementation (not to say it's easy or anything).Sidenote: turned out that in our project we're already doing some funky stuff to have a custom printer, that involves overriding some of Paraunit's classes to finally hook into what
\Paraunit\Configuration\DependencyInjection\ParallelContainerDefinitionis doing. With this inelegant hack I was able to wire my own chunker though :)Is such approach OK for you? Maybe you have a vision on how to interfere with Paraunit's DI container in a cleaner way? Anyway let me know, maybe I'll be able to help with something.