Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sync fbcode cp pg initialize #1177

Merged
merged 1 commit into from
Apr 12, 2024
Merged

sync fbcode cp pg initialize #1177

merged 1 commit into from
Apr 12, 2024

Conversation

amylittleyang
Copy link
Contributor

What does this PR do?

Restore pipeline parallel and context parallel order for backward compatibility with dependent projects in fbcode.

Before submitting

  • Did you have fun?
    • Make sure you had fun coding 🙃
  • Did you read the contributor guideline?
  • Was this discussed/approved via a Github issue? (no need for typos, doc improvements)
    • N/A
  • Did you make sure to update the docs?
    • N/A
  • Did you write any new necessary tests?
    • N/A
  • Did you update the changelog? (if needed)
    • N/A

PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Apr 12, 2024
@amylittleyang amylittleyang reopened this Apr 12, 2024
@amylittleyang amylittleyang merged commit 4d26a67 into main Apr 12, 2024
1 of 22 checks passed
@amylittleyang amylittleyang deleted the cp_pg_init_fbcode_sync branch April 12, 2024 17:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants