Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BugFix] Task loading schema validation #37

Merged
merged 1 commit into from
Nov 16, 2023
Merged

[BugFix] Task loading schema validation #37

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion benchmarl/environments/pettingzoo/simple_push.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,4 +11,3 @@
class TaskConfig:
task: str = MISSING
max_cycles: int = MISSING
local_ratio: float = MISSING
2 changes: 1 addition & 1 deletion benchmarl/environments/pettingzoo/waterworld.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ class TaskConfig:
poison_speed: float = MISSING
poison_reward: float = MISSING
food_reward: float = MISSING
encounter_rewar: float = MISSING
encounter_reward: float = MISSING
thrust_penalty: float = MISSING
local_ratio: float = MISSING
speed_features: bool = MISSING
6 changes: 4 additions & 2 deletions benchmarl/hydra_config.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ def load_experiment_from_hydra(cfg: DictConfig, task_name: str) -> Experiment:

def load_task_config_from_hydra(cfg: DictConfig, task_name: str) -> Task:
return task_config_registry[task_name].update_config(
OmegaConf.to_container(cfg, resolve=True)
OmegaConf.to_container(cfg, resolve=True, throw_on_missing=True)
)


Expand All @@ -56,5 +56,7 @@ def load_model_config_from_hydra(cfg: DictConfig) -> ModelConfig:
else:
model_class = model_config_registry[cfg.name]
return model_class(
**parse_model_config(OmegaConf.to_container(cfg, resolve=True))
**parse_model_config(
OmegaConf.to_container(cfg, resolve=True, throw_on_missing=True)
)
)
Loading