-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Docs] Readme update #19
Merged
Merged
Changes from 9 commits
Commits
Show all changes
16 commits
Select commit
Hold shift + click to select a range
84bf7d9
update
matteobettini 1d1d124
add abstract and headers
matteobettini 385f85f
amend
matteobettini b096362
improve examples
matteobettini bcaa647
Merge branch 'main' into readme
matteobettini 6000927
Merge branch 'main' into readme
matteobettini 823ff6f
remove requirements
matteobettini 1d8849c
remove nightly
matteobettini ccc7cf1
install
matteobettini 9b0874c
install
matteobettini 4153610
install
matteobettini 475ca45
install
matteobettini f06848a
install
matteobettini efc8a28
amend
matteobettini 59092ac
amend
matteobettini 6875317
amend
matteobettini File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -8,9 +8,9 @@ | |
author="Matteo Bettini", | ||
author_email="[email protected]", | ||
packages=find_packages(), | ||
install_requires=["torchrl", "tqdm", "hydra-core"], | ||
install_requires=["tqdm", "hydra-core"], | ||
extras_require={ | ||
"tasks": ["vmas>=1.2.10", "pettingzoo[all]>=1.24.1"], | ||
"vmas": ["vmas>=1.2.10"], | ||
"pettingzoo": ["pettingzoo[all]>=1.24.1"], | ||
}, | ||
include_package_data=True, | ||
) |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@vmoens
This is currently the only way i am able to install torchrl nightly.
This is because of many issues:
torchrl._torchrl
makes it so thatpip install git+https://github.com/pytorch/rl.git
andgit clone
+pip install -e .
do not workTelling the users to clone rl seems a lot to me, is there any workaround?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sorry i missed your tag
oh yes I know about that, there's an easy fix, let me take care of it