Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BugFix] Fix collect with grad #114

Merged
merged 3 commits into from
Jul 27, 2024
Merged

[BugFix] Fix collect with grad #114

merged 3 commits into from
Jul 27, 2024

Conversation

matteobettini
Copy link
Collaborator

fixes #112

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jul 26, 2024
@matteobettini matteobettini changed the title [BugFix] Collect with grad [BugFix] Fix collect with grad Jul 26, 2024
@robj0nes
Copy link

Ran a quick test, and looks good

@matteobettini matteobettini merged commit 6edcdc1 into main Jul 27, 2024
13 checks passed
@matteobettini matteobettini deleted the fix_rollout branch July 27, 2024 18:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Mis-matched TD keys causing RT Error when training with 'collect_with_grad':True
3 participants
@matteobettini @robj0nes @facebook-github-bot