resctl-bench: upload: Improve debugging when submission fails #321
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
Simple spelling fix. Signed-off-by: Christopher Obbard <[email protected]>
Currently the upload function will only work if the result to upload is found in the local directory. Canonicalize the result path so that we may find the result file anywhere on the filesystem. Signed-off-by: Christopher Obbard <[email protected]>
obbardc
force-pushed
the
wip/obbardc/bench-upload-fixes
branch
from
5e36e56
to
7da4c23
Compare
Currently we don't print a lot when the submission fails. Change the error message to be something a little more sensible as well as print the whole HTTP response text on an error for additional debugging context. Signed-off-by: Christopher Obbard <[email protected]>
Check if the HTTP status code from the Lambda function is 200 OK. If not, print the whole response for additional debugging. Signed-off-by: Christopher Obbard <[email protected]>
obbardc
force-pushed
the
wip/obbardc/bench-upload-fixes
branch
from
7da4c23
to
514ce13
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.