use consistent watchdog logic
Summary:
When it's impossible to extend the watchdog timeout because the character
device is held open by another process, we have a backup plan: wait 10s
before each step when erasing/writing flash chips so that whatever thread
manages the watchdog has an opportunity to pet it.
For some reason this logic was skipped on LF OpenBMC. Re-enable it because
regardless of whether healthd / fscd / systemd is managing the watchdog we
should do the same thing.
Test Plan:
```
0 ~/local/openbmc/tools/flashy $ ./build.sh && ./build_dev.sh && go test ./...
? github.com/facebook/openbmc/tools/flashy/flash_procedure [no test files]
? github.com/facebook/openbmc/tools/flashy/lib/logger [no test files]
? github.com/facebook/openbmc/tools/flashy/tests [no test files]
? github.com/facebook/openbmc/tools/flashy/utilities [no test files]
ok github.com/facebook/openbmc/tools/flashy 2.116s
ok github.com/facebook/openbmc/tools/flashy/checks_and_remediations/bletchley 0.006s
ok github.com/facebook/openbmc/tools/flashy/checks_and_remediations/common 0.250s
ok github.com/facebook/openbmc/tools/flashy/checks_and_remediations/galaxy100 0.009s
ok github.com/facebook/openbmc/tools/flashy/checks_and_remediations/grandteton 0.009s
ok github.com/facebook/openbmc/tools/flashy/checks_and_remediations/wedge100 0.009s
ok github.com/facebook/openbmc/tools/flashy/checks_and_remediations/yamp 0.009s
ok github.com/facebook/openbmc/tools/flashy/install 0.009s
ok github.com/facebook/openbmc/tools/flashy/lib/fileutils (cached)
ok github.com/facebook/openbmc/tools/flashy/lib/flash 0.008s
ok github.com/facebook/openbmc/tools/flashy/lib/flash/flashcp 0.008s
ok github.com/facebook/openbmc/tools/flashy/lib/flash/flashutils 0.010s
ok github.com/facebook/openbmc/tools/flashy/lib/flash/flashutils/devices 0.009s
ok github.com/facebook/openbmc/tools/flashy/lib/step 0.008s
ok github.com/facebook/openbmc/tools/flashy/lib/utils 0.443s
ok github.com/facebook/openbmc/tools/flashy/lib/validate 0.008s
ok github.com/facebook/openbmc/tools/flashy/lib/validate/image 0.008s
ok github.com/facebook/openbmc/tools/flashy/lib/validate/partition 0.022s
```
Build ephemeral fbpkg with these changes and force-flash a bletchley that's
in repair (first chip only):
```
1 ~ $ oobgrader --host macbmc1r0036p0009-oob.03.pci1 --wait --flashy-tag 9640644 --force --allow-downgrade
...
Host Workflow ID Progress Status Result
----------------------------- ------------------------------------ ---------- ----------------------- ----------------------
macbmc1r0036p0009-oob.03.pci1 041870c1-4e8b-4194-9d69-ef27dfb42286 finished WorkflowStatus.FINISHED FinishStatus.SUCCEEDED
```
-> https://fburl.com/scuba/openbmc_upgrades/5ogr4a5q
Reviewed By: williamspatrick
Differential Revision: D59917900
fbshipit-source-id: 7cd7050c75226b1badc98fb043fd9f1f98b6f3a0
