-
Notifications
You must be signed in to change notification settings - Fork 3k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Summary: no-op Use snake case for module names: - Our style guide says to use Jane Street style for anything not otherwise covered in the style guide. Jane Street style is to snake it up: `Let_syntax`, `Monad_infix`. - For consistency: in OCaml, a module is a file. Our file names are typically snake case, including for the files edited in this diff. By being consistent, we avoid switching conventions three times in the same compound name: `Typing_warning.CastNonPrimitive.cast_hint` - Ease of refactoring: it's an implementation detail whether a module lives in another file or corresponds directly to a file. Moving a module to/from a file shouldn't require painful, manual, global renames. mnemonic: no "camel" in "OCaml" Reviewed By: vassilmladenov Differential Revision: D65134093 fbshipit-source-id: 7455ef7b32a5a876e6bc2c5d9c948675244b9ab1
- Loading branch information
1 parent
ad24356
commit c3054ad
Showing
10 changed files
with
121 additions
and
107 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.