-
Notifications
You must be signed in to change notification settings - Fork 86
Use golang 1.11 from epel #2378
base: master
Are you sure you want to change the base?
Use golang 1.11 from epel #2378
Conversation
a59f51b
to
a6a6123
Compare
272630a
to
4ad48b7
Compare
Codecov Report
@@ Coverage Diff @@
## master #2378 +/- ##
=========================================
Coverage ? 70.11%
=========================================
Files ? 174
Lines ? 17121
Branches ? 0
=========================================
Hits ? 12005
Misses ? 3951
Partials ? 1165
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
findutils \ | ||
git \ | ||
$(test "$USE_GO_VERSION_FROM_WEBSITE" != 1 && echo "golang") \ | ||
golang \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I highly object against this change. I explicitly want to be able to use Go from the website in order to test out new features in builds like the coverage for example. If you find that CentOS has ditched Golang as it appears, then please fix that problem and don't just remove the ability to use Go from the website.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I highly object against this change. I explicitly want to be able to use Go from the website in order to test out new features in builds like the coverage for example.
We can still test things via a PR, can't we? Even if we keep the flag, you'd still have to send a new PR if you want to test something :)
If you find that CentOS has ditched Golang as it appears, then please fix that problem and don't just remove the ability to use Go from the website.
Using golang from epel is exactly what we want. I wasn't part of the discussion where it was decided to use golang from epel and not website but it looks like most of our services have already migrated openshiftio/openshift.io#4618
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
By testing I mean: Permanently use a feature (not only in one PR).
I'm not suggesting to not use Go from epel. I just want you to not remove the feature to be able to use Go from the website.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@kwk okay. That makes sense. I'll undo the removal of from-website
flag.
Use
epel
repository to install golang package which was deprecated in CentOS-7see: https://wiki.centos.org/Manuals/ReleaseNotes/CentOS7.1810#head-e467ac744557df926ed56dc0106f43961e5ffc38
See also openshiftio/openshift.io#4618 and fabric8-services/fabric8-cluster#47