This repository has been archived by the owner on Mar 11, 2021. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 86
WIP: Improve test data #2160
Open
kwk
wants to merge
2
commits into
fabric8-services:master
Choose a base branch
from
kwk:default_for_simple_type
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
WIP: Improve test data #2160
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kwk
changed the title
WIP: Default for simple type
WIP: Default Value for WI fields of type simple, list, enum
Jul 11, 2018
Codecov Report
@@ Coverage Diff @@
## master #2160 +/- ##
==========================================
+ Coverage 69.35% 69.41% +0.05%
==========================================
Files 170 166 -4
Lines 15995 15504 -491
==========================================
- Hits 11094 10762 -332
+ Misses 3855 3766 -89
+ Partials 1046 976 -70
Continue to review full report at Codecov.
|
kwk
requested review from
jarifibrahim,
baijum,
DhritiShikhar,
tinakurian and
michaelkleinhenz
July 12, 2018 11:02
kwk
changed the title
WIP: Default Value for WI fields of type simple, list, enum
Default Value for WI fields of type simple, list, enum
Jul 12, 2018
michaelkleinhenz
previously approved these changes
Jul 12, 2018
kwk
changed the title
Default Value for WI fields of type simple, list, enum
WIP: Default Value for WI fields of type simple, list, enum
Jul 12, 2018
[test] |
tinakurian
previously approved these changes
Jul 27, 2018
kwk
force-pushed
the
default_for_simple_type
branch
from
August 20, 2018 09:45
0b33f55
to
2c142a8
Compare
kwk
changed the title
WIP: Default Value for WI fields of type simple, list, enum
WIP: Improve test data
Aug 20, 2018
kwk
dismissed stale reviews from tinakurian and michaelkleinhenz
August 20, 2018 09:54
This PR is not ready.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm working on this PR to change the test data layout.... will write more about it soon.