Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Individual lap time observation and lap count config #108

Open
AhmadAmine998 opened this issue Jan 17, 2024 · 4 comments
Open

Individual lap time observation and lap count config #108

AhmadAmine998 opened this issue Jan 17, 2024 · 4 comments
Labels
bug Something isn't working enhancement New feature or request

Comments

@AhmadAmine998
Copy link
Collaborator

Currently, there is no option to change the number of laps that the agent drives before terminated and done are flagged as true. Additionally, the lap time observation is actually a total time observation for all (two) laps in this case.

The _check_done function would need to be rewritten to accomodate a config setting. The lap times calculation would need to be reworked to compute current lap time.

@AhmadAmine998 AhmadAmine998 added bug Something isn't working enhancement New feature or request labels Jan 17, 2024
@luigiberducci
Copy link
Collaborator

Yes, this might be part of #90.

Having the centerline, we can easily compute the lap using the progress (ie. simply check s coordinate).
The question is how to compute the lap and the laptime when starting from random positions along the track.
Shall we increase the lap everytime the car crosses the finish line?

About the lap time infos. We could return a list of lap times or the current lap time.
Any preference @AhmadAmine998 ?

@AhmadAmine998
Copy link
Collaborator Author

If the car is starting from a random position along the track, I say we re-order the s-coordinates from the centerline so that the point on the centerline with the closest index is now s=0 and increments accordingly. It should be doable using numpy roll.

I think a list of lap times can be useful if someone is implementing a controller/planner that uses a history of laptimes (i.e LMPC). It could also come in handy for debugging and performance monitoring.

@luigiberducci
Copy link
Collaborator

It is definitely doable to change the starting point but it becomes messy with multiple agents. Each vehicle would have a different lap.

@nandantumu
Copy link
Member

I think it would be nice to be able to pick a specific progress value to place the start/finish line

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Development

No branches or pull requests

3 participants