-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Axios 추가 #12
Merged
Merged
chore: Axios 추가 #12
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,20 +1,22 @@ | ||
import request from './index'; | ||
import request, { handleErrorResponse } from './index'; | ||
import { API_URL } from '../utils/constant'; | ||
|
||
export const apiGetArticleList = async () => { | ||
try { | ||
const response = await request({ url: API_URL.ARTICLES }); | ||
return response; | ||
const response = await request.get(API_URL.ARTICLES); | ||
return response.data; | ||
} catch (error) { | ||
return { error: error.message }; | ||
handleErrorResponse(error); | ||
throw error; | ||
} | ||
}; | ||
|
||
export const apiGetArticleDetail = async (id) => { | ||
try { | ||
const response = await request({ url: `${API_URL.ARTICLE_DETAIL}/${id}` }); | ||
return response; | ||
const response = await request.get(`${API_URL.ARTICLE_DETAIL}/${id}`); | ||
return response.data; | ||
} catch (error) { | ||
return { error: error.message }; | ||
handleErrorResponse(error); | ||
throw error; | ||
} | ||
}; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,17 +1,40 @@ | ||
const request = async ({ | ||
url, | ||
options = { | ||
method: 'GET', | ||
import axios from 'axios'; | ||
|
||
const instance = axios.create({ | ||
baseURL: '/', | ||
}); | ||
|
||
instance.interceptors.request.use( | ||
(config) => { | ||
return config; | ||
}, | ||
}) => { | ||
const response = await fetch(url, options); | ||
(error) => { | ||
return Promise.reject(error); | ||
}, | ||
); | ||
|
||
if (!response.ok) { | ||
const error = await response.json(); | ||
throw new Error(`서버의 응답이 올바르지 않습니다. (${response.status}): ${error.message}`); | ||
instance.interceptors.response.use( | ||
(response) => { | ||
return response; | ||
}, | ||
(error) => { | ||
return Promise.reject(new CustomError(error.message)); | ||
}, | ||
); | ||
|
||
export class CustomError extends Error { | ||
constructor(message) { | ||
super(message); | ||
this.name = 'CustomError'; | ||
} | ||
} | ||
|
||
return response.json(); | ||
export const handleErrorResponse = (error) => { | ||
if (error instanceof CustomError) { | ||
console.log('CustomError: ', error.name, error.message); | ||
return; | ||
} | ||
console.log('Error: ', error?.message); | ||
}; | ||
|
||
export default request; | ||
export default instance; |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
P2: handlerErrorResponse 라는 함수에서 처리하시면 어떨까요?
그리고, 만약에 axios에러에서 response값이 없는 에러가 발생하게 된다면 전체 앱이 뻗을 수도 있을 것 같아요.
옵셔널 체이닝으로 관련 에러 방지 해주시면 좋을 것 같아요
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
리뷰 주신 내용으로 handlerErrorResponse 함수 구현해보았습니다.