Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[REF] Deprecate pkg_resources, use importlib & packaging #121

Merged
merged 21 commits into from
Jul 3, 2024
Merged

[REF] Deprecate pkg_resources, use importlib & packaging #121

merged 21 commits into from
Jul 3, 2024

Conversation

f-dangel
Copy link
Owner

@f-dangel f-dangel commented Jul 2, 2024 •
edited
Loading

Had to explicitly install packaging and wheels in the CI because otherwise it would crash with an ImportError when trying to import packaging (note that only installing packaging was not sufficient).

@f-dangel f-dangel requested a review from runame July 2, 2024 19:29
@coveralls
Copy link

coveralls commented Jul 2, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 9766830370

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 88.867%
Totals Coverage Status
Change from base Build 9490097890: 0.0%
Covered Lines: 1333
Relevant Lines: 1500
💛 - Coveralls

@coveralls
Copy link

coveralls commented Jul 2, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 9766947425

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 88.867%
Totals Coverage Status
Change from base Build 9490097890: 0.0%
Covered Lines: 1333
Relevant Lines: 1500
💛 - Coveralls

@coveralls
Copy link

coveralls commented Jul 2, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 9766976946

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 88.867%
Totals Coverage Status
Change from base Build 9490097890: 0.0%
Covered Lines: 1333
Relevant Lines: 1500
💛 - Coveralls

@coveralls
Copy link

coveralls commented Jul 2, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 9766995538

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 88.867%
Totals Coverage Status
Change from base Build 9490097890: 0.0%
Covered Lines: 1333
Relevant Lines: 1500
💛 - Coveralls

@coveralls
Copy link

coveralls commented Jul 2, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 9767024193

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 88.867%
Totals Coverage Status
Change from base Build 9490097890: 0.0%
Covered Lines: 1333
Relevant Lines: 1500
💛 - Coveralls

@coveralls
Copy link

coveralls commented Jul 2, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 9767116115

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 88.867%
Totals Coverage Status
Change from base Build 9490097890: 0.0%
Covered Lines: 1333
Relevant Lines: 1500
💛 - Coveralls

@coveralls
Copy link

coveralls commented Jul 2, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 9767174858

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 88.867%
Totals Coverage Status
Change from base Build 9490097890: 0.0%
Covered Lines: 1333
Relevant Lines: 1500
💛 - Coveralls

@coveralls
Copy link

coveralls commented Jul 2, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 9767235120

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 88.867%
Totals Coverage Status
Change from base Build 9490097890: 0.0%
Covered Lines: 1333
Relevant Lines: 1500
💛 - Coveralls

@coveralls
Copy link

coveralls commented Jul 2, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 9767234778

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 88.867%
Totals Coverage Status
Change from base Build 9490097890: 0.0%
Covered Lines: 1333
Relevant Lines: 1500
💛 - Coveralls

@coveralls
Copy link

coveralls commented Jul 2, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 9767326306

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 88.867%
Totals Coverage Status
Change from base Build 9490097890: 0.0%
Covered Lines: 1333
Relevant Lines: 1500
💛 - Coveralls

runame
runame approved these changes Jul 2, 2024
View reviewed changes
Copy link
Collaborator

@runame runame left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@f-dangel f-dangel merged commit 84c2ce7 into main Jul 3, 2024
13 checks passed
@f-dangel f-dangel deleted the deprecate-pkg-resources branch July 3, 2024 23:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@runame runame runame approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@f-dangel @coveralls @runame