Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FIX] Scaling of MC Fisher for MSELoss and BCEWithLogitsLoss with mean reduction #112

Merged
merged 1 commit into from
May 11, 2024
Merged

[FIX] Scaling of MC Fisher for MSELoss and BCEWithLogitsLoss with mean reduction #112

merged 1 commit into from
May 11, 2024

Conversation

runame
Copy link
Collaborator

@runame runame commented May 10, 2024

Fixes #111.

@runame runame added the bug Something isn't working label May 10, 2024
@runame runame requested a review from f-dangel May 10, 2024 14:16
@runame runame self-assigned this May 10, 2024
@coveralls
Copy link

coveralls commented May 10, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 9033556162

Details

  • 0 of 2 (0.0%) changed or added relevant lines in 1 file are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage increased (+0.06%) to 88.359%
Changes Missing Coverage Covered Lines Changed/Added Lines %
curvlinops/fisher.py 0 2 0.0%
Files with Coverage Reduction New Missed Lines %
curvlinops/fisher.py 1 26.47%
Totals Coverage Status
Change from base Build 8987538117: 0.06%
Covered Lines: 1260
Relevant Lines: 1426
💛 - Coveralls

f-dangel
f-dangel approved these changes May 10, 2024
View reviewed changes
Copy link
Owner

@f-dangel f-dangel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@runame runame merged commit c8e9204 into main May 11, 2024
13 checks passed
@runame runame deleted the fix-mcfisher-scale branch May 11, 2024 11:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@f-dangel f-dangel f-dangel approved these changes

Assignees

@runame runame

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
3 participants
@runame @coveralls @f-dangel